Disable notifications while running unit tests
ClosedPublic
Actions

Authored by epriestley on Aug 6 2014, 10:26 PM.

Tags

None

Referenced Files

	F13818666: D10171.diff
	Fri, Sep 20, 9:23 AM

	Unknown Object (File)
	Sun, Sep 1, 8:29 AM

	Unknown Object (File)
	Sat, Aug 31, 9:51 AM

	Unknown Object (File)
	Sun, Aug 25, 9:18 AM

	Unknown Object (File)
	Sun, Aug 25, 6:32 AM

	Unknown Object (File)
	Aug 10 2024, 1:43 PM

	Unknown Object (File)
	Aug 6 2024, 2:27 PM

	Unknown Object (File)
	Jul 23 2024, 11:37 AM

View All Files

Subscribers

epriestley

Tokens

"Mountain of Wealth" token, awarded by joshuaspence.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP1e1eb6921b1d: Disable notifications while running unit tests

Summary

Currently, we'll try to publish notifications while running tests. This is at best unnecessary and at worst problematic (we don't stub out the server).

For now, just never publish them.

Test Plan

Ran unit tests with notifications enabled but the server down and didn't get a bunch of warnings.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24466.Aug 6 2014, 10:26 PM

epriestley retitled this revision from to Disable notifications while running unit tests.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 6 2014, 10:26 PM

btrahan accepted this revision.Aug 6 2014, 10:27 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 6 2014, 10:27 PM

Harbormaster completed remote builds in B2071: Diff 24466.Aug 6 2014, 10:27 PM

Closed by commit rP1e1eb6921b1d (authored by @epriestley).

joshuaspence awarded a token.Aug 6 2014, 10:38 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

1 line

infrastructure/

testing/

PhabricatorTestCase.php

6 lines

Diff 24467

View Options

src/__phutil_library_map__.php