Page MenuHomePhabricator

Disable notifications while running unit tests
ClosedPublic

Authored by epriestley on Aug 6 2014, 10:26 PM.
Tags
None
Referenced Files
F14009144: D10171.id24466.diff
Wed, Oct 30, 10:42 AM
F14009143: D10171.id24467.diff
Wed, Oct 30, 10:42 AM
F13997574: D10171.diff
Thu, Oct 24, 5:12 AM
F13994628: D10171.diff
Wed, Oct 23, 7:27 AM
F13994591: D10171.id24467.diff
Wed, Oct 23, 7:15 AM
F13972731: D10171.id.diff
Thu, Oct 17, 8:54 PM
Unknown Object (File)
Sep 30 2024, 7:36 PM
Unknown Object (File)
Sep 20 2024, 9:23 AM
Subscribers
Tokens
"Mountain of Wealth" token, awarded by joshuaspence.

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP1e1eb6921b1d: Disable notifications while running unit tests
Summary

Currently, we'll try to publish notifications while running tests. This is at best unnecessary and at worst problematic (we don't stub out the server).

For now, just never publish them.

Test Plan

Ran unit tests with notifications enabled but the server down and didn't get a bunch of warnings.

Diff Detail

Repository
rP Phabricator
Branch
notifunit
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2071
Build 2072: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Disable notifications while running unit tests.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2014, 10:27 PM
epriestley updated this revision to Diff 24467.

Closed by commit rP1e1eb6921b1d (authored by @epriestley).