Page MenuHomePhabricator
Differential D10148

Rename base MySQL database connection class
ClosedPublic
Actions

Authored by joshuaspence on Aug 5 2014, 1:08 PM.
Tags
None
Referenced Files
F14746092: D10148.diff
Tue, Jan 21, 9:39 AM
Unknown Object (File)
Wed, Jan 15, 5:16 PM
Unknown Object (File)
Wed, Jan 8, 4:07 AM
Unknown Object (File)
Mon, Jan 6, 9:15 PM
Unknown Object (File)
Thu, Dec 26, 5:57 AM
Unknown Object (File)
Dec 11 2024, 6:53 AM
Unknown Object (File)
Dec 8 2024, 12:53 AM
Unknown Object (File)
Dec 7 2024, 8:47 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5655: Standardize naming conventions
Commits
rPHU2d546f2e2fea: Rename base MySQL database connection class
Summary

Ref T5655. Rename AphrontMySQLDatabaseConnectionBase to AphrontBaseMySQLDatabaseConnection for consistency.

Test Plan

N/A

Diff Detail

Repository
rPHU libphutil
Branch
mysqlbase
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php:133XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 2043
Build 2044: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 24415.Aug 5 2014, 1:08 PM
joshuaspence retitled this revision from to Rename base MySQL database connection class.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T5655: Standardize naming conventions.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 5 2014, 1:08 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2043: Diff 24415.Aug 5 2014, 1:09 PM
epriestley edited edge metadata.Aug 11 2014, 9:41 PM

I think this class name is used in Phabricator configuration -- mysql.implementation -- so we'll need a migration patch for it or some code to accept either version of the class names and yell at you.

epriestley requested changes to this revision.Aug 11 2014, 9:41 PM
epriestley edited edge metadata.

(This is fine but needs a companion patch.)

This revision now requires changes to proceed.Aug 11 2014, 9:41 PM
joshuaspence added a comment.Sep 5 2014, 2:23 PM

Hmm, mysql.implementation can be set to an abstract class?

epriestley accepted this revision.Sep 5 2014, 2:43 PM
epriestley edited edge metadata.

oh, haha

well it can, but this won't make it any worse

This revision is now accepted and ready to land.Sep 5 2014, 2:43 PM
joshuaspence closed this revision.Sep 6 2014, 1:22 AM
joshuaspence updated this revision to Diff 25090.

Closed by commit rPHU2d546f2e2fea (authored by @joshuaspence).

Revision Contents
Changeset List

Diff 24415

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnection.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLDatabaseConnectionBase.php

Loading...
View Options

src/aphront/storage/connection/mysql/AphrontMySQLiDatabaseConnection.php

Loading...
Phabricator · Built by Phacility