Paths

Table of Contentst

Differential D10121

Add a `selectTokensOfTypes` method to the `AASTNode` class
ClosedPublic
Actions

Authored by joshuaspence on Aug 2 2014, 9:08 AM.

Tags

None

Referenced Files

	F13197361: D10121.diff
	Mon, May 13, 12:07 AM

	F13178682: D10121.diff
	Wed, May 8, 8:35 PM

	Unknown Object (File)
	Mon, May 6, 7:22 AM

	Unknown Object (File)
	Sat, May 4, 3:22 AM

	Unknown Object (File)
	Thu, May 2, 9:31 AM

	Unknown Object (File)
	Thu, Apr 25, 3:19 AM

	Unknown Object (File)
	Thu, Apr 18, 9:04 AM

	Unknown Object (File)
	Wed, Apr 17, 8:39 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU5b9e5b3c105a: Add a `selectTokensOfTypes` method to the `AASTNode` class

Summary

Add a selectTokensOfTypes class which allows multiple token types to be extracted from an AASTNode.

Test Plan

This will make more sense in my next diff.

Diff Detail

Repository

Branch

tokens

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2001
Build 2002: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 24343.Aug 2 2014, 9:08 AM

joshuaspence retitled this revision from to Add a `selectTokensOfTypes` method to the `AASTNode` class.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 2 2014, 9:08 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2001: Diff 24343.Aug 2 2014, 9:10 AM

epriestley accepted this revision.Aug 2 2014, 9:13 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/parser/aast/api/AASTNode.php
145	Avoid `array_merge()` in a loop. Probably easiest here to just iterate over the results explicitly rather than trying to `array_mergev()` later on. https://secure.phabricator.com/book/phabflavor/article/php_pitfalls/#array-merge-in-incredibl

This revision is now accepted and ready to land.Aug 2 2014, 9:13 AM

Don't use array_merge inside a loop

Harbormaster completed remote builds in B2002: Diff 24344.Aug 2 2014, 9:43 AM

Closed by commit rPHU5b9e5b3c105a (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

parser/

aast/

api/

29 lines

Diff 24343

src/parser/aast/api/AASTNode.php

Loading...