This fix is wrong - should be load and not get - but moreover this is actually correctly set as the reply handler is instantiated inside the DifferentialRevisionMailReceiver correctly; $this->getExclude was correct. Ref T5185.
Details
Details
- Reviewers
epriestley chad - Maniphest Tasks
- T5185: Comment emails generated from parsing incoming email replies should not go to people already on the To/CC of the incoming email
- Commits
- Restricted Diffusion Commit
rPc4cbc1a32da7: Revert attempt to fix mail in differential
this shall stop the fatal in production.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- revert
- Lint
Lint Errors Severity Location Code Message Error src/applications/phragment/controller/PhragmentZIPController.php:54 PHL1 Unknown Symbol Error src/applications/phragment/controller/PhragmentZIPController.php:70 PHL1 Unknown Symbol Error src/applications/phragment/storage/PhragmentFragment.php:143 PHL1 Unknown Symbol - Unit
Tests Passed - Build Status
Buildable 1973 Build 1974: [Placeholder Plan] Wait for 30 Seconds