Page MenuHomePhabricator

Revert attempt to fix mail in differential
ClosedPublic

Authored by btrahan on Jul 31 2014, 9:46 PM.
Tags
None
Referenced Files
F13340951: D10101.diff
Thu, Jun 20, 4:32 AM
F13305215: D10101.id24291.diff
Sat, Jun 8, 6:57 PM
F13305212: D10101.id24289.diff
Sat, Jun 8, 6:53 PM
F13283853: D10101.id24289.diff
Sun, Jun 2, 5:12 PM
F13274275: D10101.diff
Fri, May 31, 3:31 AM
F13259608: D10101.diff
Sun, May 26, 10:37 PM
F13254492: D10101.id24289.diff
Sat, May 25, 3:27 AM
F13250659: D10101.id.diff
May 24 2024, 4:07 PM
Subscribers

Details

Summary

This fix is wrong - should be load and not get - but moreover this is actually correctly set as the reply handler is instantiated inside the DifferentialRevisionMailReceiver correctly; $this->getExclude was correct. Ref T5185.

Test Plan

this shall stop the fatal in production.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Revert attempt to fix mail in differential.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 31 2014, 9:48 PM
btrahan updated this revision to Diff 24291.

Closed by commit rPc4cbc1a32da7 (authored by @btrahan).