Page MenuHomePhabricator
Differential D10088

Fix email for closing a blocking task
ClosedPublic
Actions

Authored by epriestley on Jul 31 2014, 12:03 AM.
Tags
None
Referenced Files
F14004757: D10088.id24258.diff
Sun, Oct 27, 2:17 AM
F14003952: D10088.id24258.diff
Sat, Oct 26, 1:24 PM
F14003951: D10088.id24256.diff
Sat, Oct 26, 1:24 PM
F13995475: D10088.id24256.diff
Wed, Oct 23, 1:10 PM
F13989578: D10088.id.diff
Mon, Oct 21, 9:31 PM
Unknown Object (File)
Sep 4 2024, 8:40 PM
Unknown Object (File)
Sep 1 2024, 12:25 PM
Unknown Object (File)
Aug 25 2024, 12:38 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5751: Closing a task which blocks other tasks sends an email about the wrong transaction set
Commits
Restricted Diffusion Commit
rP31343e61ceee: Fix email for closing a blocking task
Summary

Fixes T5751. Currently, we incorrectly overwrite $xactions.

Test Plan

Closed a blocking task, got an email about the correct transaction set ("closed task; added comment") instead of an overwritten transaction set ("closed blocking task").

Diff Detail

Repository
rP Phabricator
Branch
unblockvar
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1948
Build 1949: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24256.Jul 31 2014, 12:03 AM
epriestley retitled this revision from to Fix email for closing a blocking task.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T5751: Closing a task which blocks other tasks sends an email about the wrong transaction set.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 31 2014, 12:03 AM
epriestley added inline comments.Jul 31 2014, 12:04 AM
src/applications/maniphest/editor/ManiphestTransactionEditor.php
232

This is the transactions we're finalizing.

261

We incorrectly overwrote them here.

283

Then we returned the overwritten transactions.

Harbormaster completed remote builds in B1948: Diff 24256.Jul 31 2014, 12:04 AM
btrahan accepted this revision.Jul 31 2014, 12:09 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jul 31 2014, 12:09 AM
epriestley closed this revision.Jul 31 2014, 12:12 AM
epriestley updated this revision to Diff 24258.

Closed by commit rP31343e61ceee (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
editor/
6 lines

Diff 24256

View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
Phabricator · Built by Phacility