Page MenuHomePhabricator
Create Task
Maniphest T5751

Closing a task which blocks other tasks sends an email about the wrong transaction set
Closed, ResolvedPublic
Actions

Assigned To
epriestley
Authored By
wwu
Jul 30 2014, 11:09 PM
Tags
Referenced Files
F184443: blocking-task.png
Jul 30 2014, 11:55 PM
F184432: norepro.png
Jul 30 2014, 11:39 PM
Subscribers
epriestley
wwu

Description

This would make emails from tasks more useful, and I didn't find an existing task asking for it yet?

Steps to repro

  1. On an existing task, scroll to bottom
  2. Change action="change status", status="resolved"
  3. Add some comments, submit

Desired behavior
The email to subscribers should include both the status change & the new comments

Current behavior
Only the status change gets included in the email

Revisions and Commits

rP Phabricator
D10088rP31343e61ceee Fix email for closing a blocking task

Event Timeline

wwu created this task.Jul 30 2014, 11:09 PM
wwu raised the priority of this task from to Needs Triage.
wwu updated the task description. (Show Details)
wwu added a project: Maniphest.
wwu added a subscriber: wwu.
epriestley closed this task as Resolved.Jul 30 2014, 11:37 PM
epriestley claimed this task.

Just testing.

epriestley reopened this task as Open.Jul 30 2014, 11:38 PM

More testing.

epriestley added a comment.Jul 30 2014, 11:39 PM

I can't reproduce this. Here are the mails I received from my comments above:

norepro.png (870×1 px, 210 KB)

You can see the comments are included in the mail body.

Is your install extremely out of date (months old)?

wwu added a comment.Jul 30 2014, 11:55 PM

Ah, this only happens with blocking tasks. Lemme update the description. In the screenshot, the "Resolving a blocking task now" comment didn't get included in the email.

blocking-task.png (1×2 px, 519 KB)

epriestley added a comment.Jul 30 2014, 11:58 PM

Ah, that looks like a bug. Thanks, I'll take a look.

epriestley renamed this task from When using "add comment" box on a task to change status & add a comment at the same time, the summary email only includes status info and doesn't include the new comment to Closing a task which blocks other tasks sends an email about the wrong transaction set.Jul 30 2014, 11:58 PM
wwu added a comment.Jul 31 2014, 12:00 AM

Cool, thanks for taking a look!

epriestley added a revision: D10088: Fix email for closing a blocking task.Jul 31 2014, 12:03 AM
epriestley closed this task as Resolved.Jul 31 2014, 12:12 AM
epriestley added a commit: rP31343e61ceee: Fix email for closing a blocking task.

Closed by commit rP31343e61ceee.

epriestley added a comment.Jul 31 2014, 12:13 AM

This should be fixed in HEAD. Thanks for the report and helping to narrow it down, it was very helpful in getting the issue fixed. Let us know if you run into anything else!

(If you don't deploy regularly, I'll deploy to this host in a minute if you want to see if you can still repro.)

Phabricator · Built by Phacility