HomePhabricator

Prevent crash caused by empty array when rendering Pholio mocks

Description

Prevent crash caused by empty array when rendering Pholio mocks

Summary: This was causing a crash according to a conversation with @rfergu in IRC. The issue is that if $images_to_show is empty, then $image never gets set, and it attempts to call getID on a null / unset variable.

Test Plan: @rfergu confirmed this fixed the crash.

Reviewers: Blessed Reviewers, epriestley

Reviewed By: Blessed Reviewers, epriestley

Subscribers: Korvin, rfergu, epriestley

Differential Revision: https://secure.phabricator.com/D10073

Details

Provenance
hach-queAuthored on
hach-quePushed on Jul 30 2014, 10:10 PM
Reviewer
Blessed Reviewers
Differential Revision
D10073: Prevent crash caused by empty array when rendering Pholio mocks
Parents
rP8afd8f56f475: update celerity map
Branches
Unknown
Tags
Unknown

Event Timeline