Use authoritative PHIDs for Herald "Task Projects" condition
ClosedPublic
Actions

Authored by epriestley on Jul 26 2014, 12:07 PM.

Details

Reviewers

joshuaspence
btrahan
chad

Maniphest Tasks

T5707: Herald "Projects does not exist" condition doesn't seem to work

Commits

Restricted Diffusion Commit
rP0b5fcb36ae8c: Use authoritative PHIDs for Herald "Task Projects" condition

Summary

Fixes T5707. After work on T5245, the $task object may not have the correct set of task PHIDs attached to it when Herald is invoked.

Instead, just fetch the authoritative set. This is simple, and Herald is not super performance sensitive (happens on a write) so hitting the DB once is fine.

Test Plan

Created a task with projects, verified the projects field contained the correct values when processed by Herald.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24186.Jul 26 2014, 12:07 PM

epriestley retitled this revision from to Use authoritative PHIDs for Herald "Task Projects" condition.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, chad, btrahan.

epriestley added a task: T5707: Herald "Projects does not exist" condition doesn't seem to work.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 26 2014, 12:07 PM

Harbormaster completed remote builds in B1907: Diff 24186.Jul 26 2014, 12:09 PM

joshuaspence accepted this revision.Jul 26 2014, 1:47 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Jul 26 2014, 1:47 PM

Closed by commit rP0b5fcb36ae8c (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldManiphestTaskAdapter.php

4 lines

Diff 24188

View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Use authoritative PHIDs for Herald "Task Projects" conditionClosedPublicActions