Page MenuHomePhabricator
Differential D10060

Use authoritative PHIDs for Herald "Task Projects" condition
ClosedPublic
Actions

Authored by epriestley on Jul 26 2014, 12:07 PM.
Tags
None
Referenced Files
F14067521: D10060.diff
Tue, Nov 19, 3:22 PM
F14061908: D10060.diff
Mon, Nov 18, 9:19 AM
F14061496: D10060.id24186.diff
Mon, Nov 18, 6:48 AM
F14049974: D10060.diff
Thu, Nov 14, 3:43 PM
F14036482: D10060.diff
Sun, Nov 10, 10:25 AM
F14022032: D10060.diff
Wed, Nov 6, 2:53 PM
F14002180: D10060.diff
Fri, Oct 25, 4:03 PM
F13996832: D10060.id24188.diff
Thu, Oct 24, 12:21 AM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
chad
Maniphest Tasks
T5707: Herald "Projects does not exist" condition doesn't seem to work
Commits
Restricted Diffusion Commit
rP0b5fcb36ae8c: Use authoritative PHIDs for Herald "Task Projects" condition
Summary

Fixes T5707. After work on T5245, the $task object may not have the correct set of task PHIDs attached to it when Herald is invoked.

Instead, just fetch the authoritative set. This is simple, and Herald is not super performance sensitive (happens on a write) so hitting the DB once is fine.

Test Plan

Created a task with projects, verified the projects field contained the correct values when processed by Herald.

Diff Detail

Repository
rP Phabricator
Branch
hproject
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1907
Build 1908: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24186.Jul 26 2014, 12:07 PM
epriestley retitled this revision from to Use authoritative PHIDs for Herald "Task Projects" condition.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, chad, btrahan.
epriestley added a task: T5707: Herald "Projects does not exist" condition doesn't seem to work.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 26 2014, 12:07 PM
Harbormaster completed remote builds in B1907: Diff 24186.Jul 26 2014, 12:09 PM
joshuaspence accepted this revision.Jul 26 2014, 1:47 PM
joshuaspence edited edge metadata.
This revision is now accepted and ready to land.Jul 26 2014, 1:47 PM
epriestley closed this revision.Jul 26 2014, 4:48 PM
epriestley updated this revision to Diff 24188.

Closed by commit rP0b5fcb36ae8c (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
adapter/
4 lines

Diff 24186

View Options

src/applications/herald/adapter/HeraldManiphestTaskAdapter.php

Loading...
Phabricator · Built by Phacility