Page MenuHomePhabricator
Differential D10000

Utilize `PhutilMethodNotImplementedException`
ClosedPublic
Actions

Authored by joshuaspence on Jul 21 2014, 3:38 PM.
Tags
None
Referenced Files
F13272962: D10000.diff
Fri, May 31, 1:23 AM
F13240186: D10000.id24037.diff
Wed, May 22, 11:28 AM
F13215663: D10000.id.diff
Fri, May 17, 7:03 PM
F13202714: D10000.diff
Tue, May 14, 11:02 PM
F13200496: D10000.id24037.diff
Tue, May 14, 12:38 AM
F13200495: D10000.id24036.diff
Tue, May 14, 12:38 AM
F13200455: D10000.id.diff
Tue, May 14, 12:21 AM
F13200368: D10000.diff
Mon, May 13, 11:30 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Evil Spooky Haunted Tree" token, awarded by btrahan.

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP8999a1c1ea55: Utilize `PhutilMethodNotImplementedException`
Summary

Depends on D9992. Utilize the PhutilMethodNotImplementedException class.

Test Plan

N/A

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 24036.Jul 21 2014, 3:38 PM
joshuaspence retitled this revision from to Utilize `PhutilMethodNotImplementedException`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D9992: Add a `PhutilMethodNotImplementedException` class.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 21 2014, 3:38 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
epriestley edited edge metadata.Jul 21 2014, 3:38 PM

worst D10K

Harbormaster completed remote builds in B1812: Diff 24036.Jul 21 2014, 3:39 PM
joshuaspence added a comment.Jul 21 2014, 3:40 PM

I kept refreshing to see if anyone else was going to submit something but gave up.

deal-with-it

epriestley accepted this revision.Jul 21 2014, 3:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 21 2014, 3:41 PM
joshuaspence closed this revision.Jul 21 2014, 3:47 PM
joshuaspence updated this revision to Diff 24037.

Closed by commit rP8999a1c1ea55 (authored by @joshuaspence).

btrahan awarded a token.Jul 29 2014, 10:31 PM

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
provider/
4 lines
differential/
render/
12 lines
12 lines
phid/
type/
2 lines
search/
engine/
2 lines
transactions/
editor/
2 lines
storage/
2 lines

Diff 24037

View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTestRenderer.php

Loading...
View Options

src/applications/phid/type/PhabricatorPHIDType.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Loading...
Phabricator · Built by Phacility