Maybe an argument for PhutilAuth...Adapter but this is probably more reasonable. I could maybe imagine even libphutil becoming more application-oriented in the future, though.

This revision is now accepted and ready to land.Jul 21 2014, 3:26 PM

joshuaspence retitled this revision from Rename auth classes for consistency. to Rename auth classes for consistency.Jul 21 2014, 10:57 PM

joshuaspence edited edge metadata.

Leave PhutilAuthUserAbortedException as is.
Whitespace changes

Harbormaster completed remote builds in B1826: Diff 24056.Jul 22 2014, 11:01 AM

Closed by commit rPHU57daed582f2c (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

68 lines

auth/

	PhutilAmazonAuthAdapter.php
	PhutilAuthAdapterOAuthAmazon.php

2 lines

	PhutilAsanaAuthAdapter.php
	PhutilAuthAdapterOAuthAsana.php

2 lines

PhutilAuthAdapterEmpty.php

PhutilAuthAdapterLDAP.php

PhutilAuthAdapterOAuth.php

PhutilAuthAdapterOAuth1.php

PhutilAuthAdapterOAuthAmazon.php

PhutilAuthAdapterOAuthAsana.php

PhutilAuthAdapterOAuthBitbucket.php

PhutilAuthAdapterOAuthDisqus.php

PhutilAuthAdapterOAuthFacebook.php

PhutilAuthAdapterOAuthGitHub.php

PhutilAuthAdapterOAuthGoogle.php

PhutilAuthAdapterOAuthJIRA.php

PhutilAuthAdapterOAuthTwitch.php

PhutilAuthAdapterOAuthTwitter.php

PhutilAuthAdapterOAuthWordPress.php

PhutilAuthAdapterPersona.php

	PhutilBitbucketAuthAdapter.php
	PhutilAuthAdapterOAuthBitbucket.php

2 lines

	PhutilDisqusAuthAdapter.php
	PhutilAuthAdapterOAuthDisqus.php

2 lines

	PhutilEmptyAuthAdapter.php
	PhutilAuthAdapterEmpty.php

2 lines

	PhutilFacebookAuthAdapter.php
	PhutilAuthAdapterOAuthFacebook.php

2 lines

	PhutilGitHubAuthAdapter.php
	PhutilAuthAdapterOAuthGitHub.php

4 lines

	PhutilGoogleAuthAdapter.php
	PhutilAuthAdapterOAuthGoogle.php

2 lines

	PhutilJIRAAuthAdapter.php
	PhutilAuthAdapterOAuthJIRA.php

2 lines

	PhutilLDAPAuthAdapter.php
	PhutilAuthAdapterLDAP.php

2 lines

	PhutilOAuth1AuthAdapter.php
	PhutilAuthAdapterOAuth1.php

2 lines

	PhutilOAuthAuthAdapter.php
	PhutilAuthAdapterOAuth.php

2 lines

	PhutilPersonaAuthAdapter.php
	PhutilAuthAdapterPersona.php

2 lines

	PhutilTwitchAuthAdapter.php
	PhutilAuthAdapterOAuthTwitch.php

2 lines

	PhutilTwitterAuthAdapter.php
	PhutilAuthAdapterOAuthTwitter.php

3 lines

	PhutilWordPressAuthAdapter.php
	PhutilAuthAdapterOAuthWordPress.php

2 lines

exception/

PhutilAuthUserAbortedException.php

	PhutilUserAbortedAuthException.php
	PhutilAuthUserAbortedException.php

4 lines

Diff 24033

View Options

src/__phutil_library_map__.php

View Options

src/auth/PhutilAmazonAuthAdapter.php

View Options

src/auth/PhutilAsanaAuthAdapter.php

View Options

src/auth/PhutilAuthAdapterEmpty.php

View Options

src/auth/PhutilAuthAdapterLDAP.php

View Options

src/auth/PhutilAuthAdapterOAuth.php

View Options

src/auth/PhutilAuthAdapterOAuth1.php

View Options

src/auth/PhutilAuthAdapterOAuthAmazon.php

View Options

src/auth/PhutilAuthAdapterOAuthAsana.php

View Options

src/auth/PhutilAuthAdapterOAuthBitbucket.php

View Options

src/auth/PhutilAuthAdapterOAuthDisqus.php

View Options

src/auth/PhutilAuthAdapterOAuthFacebook.php

View Options

src/auth/PhutilAuthAdapterOAuthGitHub.php

View Options

src/auth/PhutilAuthAdapterOAuthGoogle.php

View Options

src/auth/PhutilAuthAdapterOAuthJIRA.php

View Options

src/auth/PhutilAuthAdapterOAuthTwitch.php

View Options

src/auth/PhutilAuthAdapterOAuthTwitter.php

View Options

src/auth/PhutilAuthAdapterOAuthWordPress.php

View Options

src/auth/PhutilAuthAdapterPersona.php

View Options

src/auth/PhutilBitbucketAuthAdapter.php

View Options

src/auth/PhutilDisqusAuthAdapter.php

View Options

src/auth/PhutilEmptyAuthAdapter.php

View Options

src/auth/PhutilFacebookAuthAdapter.php

View Options

src/auth/PhutilGitHubAuthAdapter.php

View Options

src/auth/PhutilGoogleAuthAdapter.php

View Options

src/auth/PhutilJIRAAuthAdapter.php

View Options

src/auth/PhutilLDAPAuthAdapter.php

View Options

src/auth/PhutilOAuth1AuthAdapter.php

View Options

src/auth/PhutilOAuthAuthAdapter.php

View Options

src/auth/PhutilPersonaAuthAdapter.php

View Options

src/auth/PhutilTwitchAuthAdapter.php

View Options

src/auth/PhutilTwitterAuthAdapter.php

View Options

src/auth/PhutilWordPressAuthAdapter.php

View Options

src/auth/exception/PhutilAuthUserAbortedException.php

View Options

src/auth/exception/PhutilUserAbortedAuthException.php

Rename auth classes for consistencyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24033

src/__phutil_library_map__.php

src/auth/PhutilAmazonAuthAdapter.php

src/auth/PhutilAsanaAuthAdapter.php

src/auth/PhutilAuthAdapterEmpty.php

src/auth/PhutilAuthAdapterLDAP.php

src/auth/PhutilAuthAdapterOAuth.php

src/auth/PhutilAuthAdapterOAuth1.php

src/auth/PhutilAuthAdapterOAuthAmazon.php

src/auth/PhutilAuthAdapterOAuthAsana.php

src/auth/PhutilAuthAdapterOAuthBitbucket.php

src/auth/PhutilAuthAdapterOAuthDisqus.php

src/auth/PhutilAuthAdapterOAuthFacebook.php

src/auth/PhutilAuthAdapterOAuthGitHub.php

src/auth/PhutilAuthAdapterOAuthGoogle.php

src/auth/PhutilAuthAdapterOAuthJIRA.php

src/auth/PhutilAuthAdapterOAuthTwitch.php

src/auth/PhutilAuthAdapterOAuthTwitter.php

src/auth/PhutilAuthAdapterOAuthWordPress.php

src/auth/PhutilAuthAdapterPersona.php

src/auth/PhutilBitbucketAuthAdapter.php

src/auth/PhutilDisqusAuthAdapter.php

src/auth/PhutilEmptyAuthAdapter.php

src/auth/PhutilFacebookAuthAdapter.php

src/auth/PhutilGitHubAuthAdapter.php

src/auth/PhutilGoogleAuthAdapter.php

src/auth/PhutilJIRAAuthAdapter.php

src/auth/PhutilLDAPAuthAdapter.php

src/auth/PhutilOAuth1AuthAdapter.php

src/auth/PhutilOAuthAuthAdapter.php

src/auth/PhutilPersonaAuthAdapter.php

src/auth/PhutilTwitchAuthAdapter.php

src/auth/PhutilTwitterAuthAdapter.php

src/auth/PhutilWordPressAuthAdapter.php

src/auth/exception/PhutilAuthUserAbortedException.php

src/auth/exception/PhutilUserAbortedAuthException.php

Rename auth classes for consistency
ClosedPublic
Actions

Revision Contents
Changeset List