Page MenuHomePhabricator
Differential D9975

Explicitly degrade edge editing for commit/task edges until T4896
ClosedPublic
Actions

Authored by epriestley on Jul 18 2014, 12:59 AM.
Tags
None
Referenced Files
F13157283: D9975.diff
Sun, May 5, 10:32 AM
Unknown Object (File)
Fri, May 3, 7:27 AM
Unknown Object (File)
Wed, Apr 24, 10:44 PM
Unknown Object (File)
Sat, Apr 20, 1:19 AM
Unknown Object (File)
Apr 3 2024, 6:50 PM
Unknown Object (File)
Mar 13 2024, 12:24 PM
Unknown Object (File)
Feb 13 2024, 5:16 PM
Unknown Object (File)
Feb 8 2024, 4:48 AM
View All Files
Subscribers
epriestley
Tokens
"Like" token, awarded by joshuaspence.

Details

Reviewers
joshuaspence
Commits
Restricted Diffusion Commit
rP17afcdcf9532: Explicitly degrade edge editing for commit/task edges until T4896
Summary

Commits don't support PhabricatorApplicationTransactionInterface yet, so the "Edit Maniphest Tasks" dialog from the commit UI currently bombs.

Hard-code it to do the correct writes in a low-level way. After T4896 we can remove this and do ApplicationTransaction stuff.

Test Plan

Used the "Edit Maniphest Tasks" UI from Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
uiedge
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/search/controller/PhabricatorSearchAttachController.php:61XHP16TODO Comment
Unit
No Test Coverage
Build Status
Buildable 1761
Build 1762: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23968.Jul 18 2014, 12:59 AM
epriestley retitled this revision from to Explicitly degrade edge editing for commit/task edges until T4896.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 18 2014, 12:59 AM
joshuaspence accepted this revision.Jul 18 2014, 1:30 AM
joshuaspence updated this object.
joshuaspence edited edge metadata.

Tested on our install and it works.

This revision is now accepted and ready to land.Jul 18 2014, 1:30 AM
Harbormaster completed remote builds in B1761: Diff 23968.Jul 18 2014, 1:30 AM
epriestley closed this revision.Jul 18 2014, 1:37 AM
epriestley updated this revision to Diff 23978.

Closed by commit rP17afcdcf9532 (authored by @epriestley).

joshuaspence awarded a token.Jul 19 2014, 2:48 AM

Revision Contents
Changeset List

PathSize
src/
applications/
search/
controller/
84 lines

Diff 23968

View Options

src/applications/search/controller/PhabricatorSearchAttachController.php

Loading...
Phabricator · Built by Phacility