Page MenuHomePhabricator
Differential D9965

Adjust Phriction remarkup rule priority
ClosedPublic
Actions

Authored by epriestley on Jul 17 2014, 7:17 PM.
Tags
None
Referenced Files
F14055735: D9965.diff
Sat, Nov 16, 3:16 PM
F14044233: D9965.diff
Tue, Nov 12, 3:31 PM
F14026337: D9965.diff
Fri, Nov 8, 1:03 AM
F13988796: D9965.id23918.diff
Mon, Oct 21, 4:01 PM
F13981849: D9965.diff
Oct 19 2024, 7:28 PM
Unknown Object (File)
Oct 8 2024, 8:53 PM
Unknown Object (File)
Sep 5 2024, 3:20 PM
Unknown Object (File)
Sep 5 2024, 3:20 PM
View All Files
Subscribers
epriestley

Details

Reviewers
joshuaspence
btrahan
Maniphest Tasks
T5645: Diviner URL points to wrong Phabricator install
Commits
Restricted Diffusion Commit
rPca83e4c6a864: Adjust Phriction remarkup rule priority
Summary

Fixes T5645. See D9964.

Test Plan

Accurate link for [[ xyz | T25 ]].

Here are the priorities:

0 PhutilRemarkupRuleEscapeRemarkup
100 PhutilRemarkupRuleMonospace
150 PhutilRemarkupRuleDocumentLink
175 PhrictionRemarkupRule
200 HarbormasterRemarkupRule
200 PhabricatorRemarkupRuleEmbedFile
200 DivinerRemarkupRuleSymbol
200 PhabricatorCountdownRemarkupRule
200 LegalpadDocumentRemarkupRule
200 PhabricatorRemarkupRuleMeme
200 PassphraseRemarkupRule
200 PhabricatorRemarkupRuleIcon
200 SlowvoteRemarkupRule
200 HeraldRemarkupRule
200 PhabricatorPasteRemarkupRule
200 ProjectRemarkupRule
200 DiffusionCommitRemarkupRule
200 DiffusionRepositoryRemarkupRule
200 DifferentialRemarkupRule
200 PonderRemarkupRule
200 ManiphestRemarkupRule
200 PhabricatorDashboardRemarkupRule
200 PholioRemarkupRule
350 PhabricatorRemarkupRuleYoutube
350 DoorkeeperRemarkupRuleAsana
350 DoorkeeperRemarkupRuleJIRA
400 PhutilRemarkupRuleHyperlink
500 CustomInlineCodeRule
500 CustomInlineJIRA5Rule
500 PhabricatorRemarkupRuleImageMacro
500 PhabricatorRemarkupRuleMention
1000 PhutilRemarkupRuleBold
1000 PhutilRemarkupRuleUnderline
1000 PhutilRemarkupRuleDel
1000 PhutilRemarkupRuleItalic

Diff Detail

Repository
rP Phabricator
Branch
priority2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1743
Build 1744: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 23907.Jul 17 2014, 7:17 PM
epriestley retitled this revision from to Adjust Phriction remarkup rule priority.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: joshuaspence, btrahan.
epriestley added a task: T5645: Diviner URL points to wrong Phabricator install.
Herald added a subscriber: epriestley. · View Herald TranscriptJul 17 2014, 7:17 PM
epriestley updated this revision to Diff 23908.Jul 17 2014, 7:18 PM
  • Also bump verison.
Harbormaster completed remote builds in B1743: Diff 23907.Jul 17 2014, 7:18 PM
Harbormaster completed remote builds in B1744: Diff 23908.
joshuaspence accepted this revision.Jul 17 2014, 9:37 PM
joshuaspence edited edge metadata.

Thanks, this works.

This revision is now accepted and ready to land.Jul 17 2014, 9:37 PM
joshuaspence added a comment.Jul 17 2014, 9:40 PM

Those priorities sure do look fun to mainain.

burnittotheground

epriestley added a comment.Jul 17 2014, 9:44 PM

If we hit any more of this we can add some unit tests for it to Phabricator. The libphutil ones are pretty stable since we have a test suite there, we just don't have a combined test suite with the Phabricator rules.

epriestley closed this revision.Jul 17 2014, 9:49 PM
epriestley updated this revision to Diff 23918.

Closed by commit rPca83e4c6a864 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
remarkup/
2 lines

Diff 23907

View Options

src/applications/phriction/remarkup/PhrictionRemarkupRule.php

Loading...
Phabricator · Built by Phacility