Adjust rule priorities to deal with links to object names correctly
ClosedPublic
Actions

Authored by epriestley on Jul 17 2014, 7:16 PM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T5645: Diviner URL points to wrong Phabricator install

Commits

rPHU4e015b989b73: Adjust rule priorities to deal with links to object names correctly

Summary

Ref T5645. The object rules got juggled to deal with some other issues, so these rules currently fire too late for [[ http://... | T25 ]], as the object rule hits T25 first.

Test Plan

Got correct render out of [[ http://... | T25 ]].

Diff Detail

Repository

rPHU libphutil

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 23906.Jul 17 2014, 7:16 PM

epriestley retitled this revision from to Adjust rule priorities to deal with links to object names correctly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: joshuaspence, btrahan.

epriestley added a task: T5645: Diviner URL points to wrong Phabricator install.

Herald added a subscriber: epriestley. · View Herald TranscriptJul 17 2014, 7:16 PM

Harbormaster completed remote builds in B1742: Diff 23906.Jul 17 2014, 7:17 PM

joshuaspence accepted this revision.Jul 17 2014, 9:37 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Jul 17 2014, 9:37 PM

Closed by commit rPHU4e015b989b73 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

remarkup/

markuprule/

PhutilRemarkupRuleDocumentLink.php

2 lines

Diff 23916

View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupRuleDocumentLink.php

Adjust rule priorities to deal with links to object names correctlyClosedPublicActions