Page MenuHomePhabricator

Minor improvement to XHPASTSyntaxErrorException message
ClosedPublic

Authored by joshuaspence on Jul 17 2014, 1:38 PM.
Tags
None
Referenced Files
F15384917: D9961.id23903.diff
Fri, Mar 14, 9:10 PM
F15344816: D9961.diff
Mon, Mar 10, 6:50 AM
Unknown Object (File)
Feb 15 2025, 5:52 PM
Unknown Object (File)
Feb 9 2025, 7:18 PM
Unknown Object (File)
Feb 9 2025, 2:17 PM
Unknown Object (File)
Feb 9 2025, 2:16 PM
Unknown Object (File)
Feb 9 2025, 2:16 PM
Unknown Object (File)
Feb 9 2025, 2:16 PM
Subscribers

Details

Summary

Trim trailing newline from exception message.

Test Plan

Before

> ./scripts/phutil_symbols.php test.php
{
  "error" : "XHPAST Parse Error: syntax error, unexpected $end, expecting T_FUNCTION on line 4\n",
  "line"  : "4",
  "file"  : "\/home\/joshua\/workspace\/github.com\/phacility\/libphutil\/foo.php"
}

After

> ./scripts/phutil_symbols.php test.php
{
  "error" : "XHPAST Parse Error: syntax error, unexpected $end, expecting T_FUNCTION on line 4",
  "line"  : "4",
  "file"  : "\/home\/joshua\/workspace\/github.com\/phacility\/libphutil\/foo.php"
}

Diff Detail

Repository
rPHU libphutil
Branch
treeerr
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1739
Build 1740: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Minor improvement to XHPASTSyntaxErrorException message.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 2:14 PM