Remove "Stopped" logic from Phrequent workflows
ClosedPublic
Actions

Authored by hach-que on Jul 17 2014, 2:02 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARCa9535446579a: Remove "Stopped" logic from Phrequent workflows

Summary

We can remove this "Stopped" code as per feedback on D7327. I think having the full text of "In Progress" and "Suspended" is much clearer than just a '*' though, so I've only removed the ongoing check.

Test Plan

Ran a combination of arc start, arc stop and arc time and it all worked.

Diff Detail

Repository

rARC Arcanist

Branch

remove-stopped-logic

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1732
Build 1733: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 23892.Jul 17 2014, 2:02 AM

hach-que retitled this revision from to Remove "Stopped" logic from Phrequent workflows.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 17 2014, 2:02 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1732: Diff 23892.Jul 17 2014, 2:03 AM

epriestley accepted this revision.Jul 17 2014, 2:14 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 17 2014, 2:14 AM

Closed by commit rARCa9535446579a (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistPhrequentWorkflow.php

10 lines

Diff 23892

View Options

src/workflow/ArcanistPhrequentWorkflow.php

Remove "Stopped" logic from Phrequent workflowsClosedPublicActions