Page MenuHomePhabricator

Remove "Stopped" logic from Phrequent workflows
ClosedPublic

Authored by hach-que on Jul 17 2014, 2:02 AM.
Tags
None
Referenced Files
F14078389: D9955.diff
Fri, Nov 22, 3:36 AM
Unknown Object (File)
Mon, Nov 18, 12:59 AM
Unknown Object (File)
Thu, Nov 14, 8:26 AM
Unknown Object (File)
Sun, Nov 10, 12:46 PM
Unknown Object (File)
Sat, Nov 9, 8:11 PM
Unknown Object (File)
Wed, Nov 6, 4:44 AM
Unknown Object (File)
Tue, Oct 29, 7:38 AM
Unknown Object (File)
Sat, Oct 26, 6:09 PM
Subscribers

Details

Summary

We can remove this "Stopped" code as per feedback on D7327. I think having the full text of "In Progress" and "Suspended" is much clearer than just a '*' though, so I've only removed the ongoing check.

Test Plan

Ran a combination of arc start, arc stop and arc time and it all worked.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

hach-que retitled this revision from to Remove "Stopped" logic from Phrequent workflows.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 17 2014, 2:14 AM
hach-que updated this revision to Diff 23895.

Closed by commit rARCa9535446579a (authored by @hach-que).