Paths

Table of Contentst

Minor change to `ArcanistXHPASTLinter`
ClosedPublic
Actions

Authored by joshuaspence on Jul 11 2014, 7:05 AM.

Tags

None

Referenced Files

	F14033853: D9893.diff
	Sat, Nov 9, 8:25 PM

	F14021063: D9893.diff
	Wed, Nov 6, 4:59 AM

	F14008545: D9893.id23757.diff
	Tue, Oct 29, 11:58 PM

	F14008544: D9893.id23752.diff
	Tue, Oct 29, 11:58 PM

	F14008542: D9893.id.diff
	Tue, Oct 29, 11:58 PM

	F14005917: D9893.diff
	Sun, Oct 27, 9:54 PM

	F13970102: D9893.id23752.diff
	Thu, Oct 17, 5:44 AM

	F13966089: D9893.diff
	Wed, Oct 16, 6:07 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC806f21315a57: Minor change to `ArcanistXHPASTLinter`

Summary

Change == to ===. This is a little bit cleaner because we shouldn't need type coercion here.

Test Plan

Ran arc unit.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23752.Jul 11 2014, 7:05 AM

joshuaspence retitled this revision from to Minor change to `ArcanistXHPASTLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 11 2014, 7:05 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1640: Diff 23752.Jul 11 2014, 7:06 AM

epriestley accepted this revision.Jul 11 2014, 11:17 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 11 2014, 11:17 AM

Closed by commit rARC806f21315a57 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

170 lines

Diff 23757

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Minor change to `ArcanistXHPASTLinter`ClosedPublicActions