Paths

Table of Contentst

Minor change to `ArcanistXHPASTLinter`
ClosedPublic
Actions

Authored by joshuaspence on Jul 11 2014, 7:05 AM.

Tags

None

Referenced Files

	F15198939: D9893.diff
	Sun, Feb 23, 5:47 AM

	Unknown Object (File)
	Fri, Feb 21, 7:42 AM

	Unknown Object (File)
	Sun, Feb 9, 8:08 AM

	Unknown Object (File)
	Sat, Feb 8, 4:58 PM

	Unknown Object (File)
	Thu, Feb 6, 9:32 PM

	Unknown Object (File)
	Thu, Feb 6, 6:37 PM

	Unknown Object (File)
	Sat, Jan 25, 2:09 AM

	Unknown Object (File)
	Fri, Jan 24, 1:15 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC806f21315a57: Minor change to `ArcanistXHPASTLinter`

Summary

Change == to ===. This is a little bit cleaner because we shouldn't need type coercion here.

Test Plan

Ran arc unit.

Diff Detail

Repository

rARC Arcanist

Branch

xhpast-===

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1640
Build 1641: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23752.Jul 11 2014, 7:05 AM

joshuaspence retitled this revision from to Minor change to `ArcanistXHPASTLinter`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 11 2014, 7:05 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1640: Diff 23752.Jul 11 2014, 7:06 AM

epriestley accepted this revision.Jul 11 2014, 11:17 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 11 2014, 11:17 AM

Closed by commit rARC806f21315a57 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

170 lines

Diff 23752

View Options

src/lint/linter/ArcanistXHPASTLinter.php

Minor change to `ArcanistXHPASTLinter`ClosedPublicActions