Page MenuHomePhabricator

Fix duplicated "Done" output
ClosedPublic

Authored by joshuaspence on Jul 10 2014, 3:30 AM.
Tags
None
Referenced Files
F13280940: D9870.diff
Sun, Jun 2, 9:29 AM
F13267526: D9870.diff
Wed, May 29, 3:35 AM
F13258643: D9870.id23688.diff
Sun, May 26, 11:26 AM
F13253130: D9870.diff
Sat, May 25, 2:25 AM
F13247648: D9870.diff
Thu, May 23, 9:18 PM
F13231287: D9870.diff
Tue, May 21, 12:21 AM
F13186435: D9870.diff
Sat, May 11, 3:37 AM
Unknown Object (File)
May 7 2024, 5:36 AM
Subscribers

Details

Summary

PhutilLibraryMapBuilder outputs "Done" twice, once implicitly from PhutilConsoleProgressBar and another explicitly.

Test Plan

Before

> arc liberate src
Finding source files...
Found 350 files.
Loading symbol cache...
Found 0 files in cache.
Analyzing 350 files with 8 subprocesses...
Done.

Done.
Building library map...
Writing map...

After

> arc liberate src
Finding source files...
Found 350 files.
Loading symbol cache...
Found 349 files in cache.
Analyzing 1 files with 8 subprocesses...
Done.
Building library map...
Writing map...

Diff Detail

Repository
rPHU libphutil
Branch
dupedone
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1600
Build 1601: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Fix duplicated "Done" output.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jul 10 2014, 11:41 AM