Page MenuHomePhabricator
Differential D9861

Separate map building and updating in `PhutilLibraryMapBuilder`
ClosedPublic
Actions

Authored by joshuaspence on Jul 9 2014, 9:10 PM.
Tags
None
Referenced Files
F14305200: D9861.id23667.diff
Tue, Dec 17, 9:21 PM
F14305199: D9861.id23660.diff
Tue, Dec 17, 9:21 PM
F14305194: D9861.id23661.diff
Tue, Dec 17, 9:21 PM
F14305193: D9861.id23666.diff
Tue, Dec 17, 9:21 PM
Unknown Object (File)
Mon, Dec 16, 5:50 PM
Unknown Object (File)
Fri, Dec 13, 2:22 AM
Unknown Object (File)
Tue, Dec 10, 5:23 PM
Unknown Object (File)
Sat, Dec 7, 12:44 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUa5c097a1070f: Separate map building and updating in `PhutilLibraryMapBuilder`
Summary

Separate the building of the library map from the writing of the library map to file. This is a much nicer approach.

Test Plan

Ran ./scripts/phutil_rebuild_map.php src and ./scripts/phutil_rebuild_map.php --show src.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1588
Build 1589: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23660.Jul 9 2014, 9:10 PM
joshuaspence retitled this revision from to Separate map building and updating in `PhutilLibraryMapBuilder`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 9 2014, 9:10 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
joshuaspence updated this revision to Diff 23661.Jul 9 2014, 9:11 PM
joshuaspence edited edge metadata.

Also update PhutilInfrastructureTestCase

Harbormaster completed remote builds in B1587: Diff 23660.Jul 9 2014, 9:11 PM
Harbormaster completed remote builds in B1588: Diff 23661.
epriestley accepted this revision.Jul 9 2014, 9:31 PM
epriestley edited edge metadata.

Maybe call updateMap() something like writeMap() or updateAndWriteMap(), it's not as clear as it could be from the outside that "update" implies "write to disk".

This revision is now accepted and ready to land.Jul 9 2014, 9:31 PM
epriestley added a comment.Jul 9 2014, 9:32 PM

Well, writeMap would be confusing with writeLibraryMap. Maybe buildMap() to generate + return, and buildAndWriteMap() to generate + write.

joshuaspence updated this revision to Diff 23666.Jul 9 2014, 9:34 PM
joshuaspence edited edge metadata.
  • Rename updateMap to updateAndWriteMap
joshuaspence closed this revision.Jul 9 2014, 9:35 PM
joshuaspence updated this revision to Diff 23667.

Closed by commit rPHUa5c097a1070f (authored by @joshuaspence).

Harbormaster completed remote builds in B1593: Diff 23666.Jul 9 2014, 9:35 PM

Revision Contents
Changeset List

PathSize
scripts/
8 lines
src/
__tests__/
2 lines
moduleutils/
36 lines

Diff 23661

View Options

scripts/phutil_rebuild_map.php

Loading...
View Options

src/__tests__/PhutilInfrastructureTestCase.php

Loading...
View Options

src/moduleutils/PhutilLibraryMapBuilder.php

Loading...
Phabricator · Built by Phacility