Page MenuHomePhabricator

Separate map building and updating in `PhutilLibraryMapBuilder`
ClosedPublic

Authored by joshuaspence on Jul 9 2014, 9:10 PM.
Tags
None
Referenced Files
F14028902: D9861.id23666.diff
Fri, Nov 8, 5:46 PM
F14009234: D9861.id23667.diff
Wed, Oct 30, 1:12 PM
F14009233: D9861.id23661.diff
Wed, Oct 30, 1:11 PM
F14009232: D9861.id23660.diff
Wed, Oct 30, 1:11 PM
F14009230: D9861.id23666.diff
Wed, Oct 30, 1:10 PM
F14009229: D9861.id.diff
Wed, Oct 30, 1:10 PM
F14009219: D9861.diff
Wed, Oct 30, 12:50 PM
F13996650: D9861.id23661.diff
Wed, Oct 23, 10:54 PM
Subscribers

Details

Summary

Separate the building of the library map from the writing of the library map to file. This is a much nicer approach.

Test Plan

Ran ./scripts/phutil_rebuild_map.php src and ./scripts/phutil_rebuild_map.php --show src.

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1588
Build 1589: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Separate map building and updating in `PhutilLibraryMapBuilder`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence edited edge metadata.

Also update PhutilInfrastructureTestCase

epriestley edited edge metadata.

Maybe call updateMap() something like writeMap() or updateAndWriteMap(), it's not as clear as it could be from the outside that "update" implies "write to disk".

This revision is now accepted and ready to land.Jul 9 2014, 9:31 PM

Well, writeMap would be confusing with writeLibraryMap. Maybe buildMap() to generate + return, and buildAndWriteMap() to generate + write.

joshuaspence edited edge metadata.
  • Rename updateMap to updateAndWriteMap