Separate the building of the library map from the writing of the library map to file. This is a much nicer approach.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rPHUa5c097a1070f: Separate map building and updating in `PhutilLibraryMapBuilder`
Ran ./scripts/phutil_rebuild_map.php src and ./scripts/phutil_rebuild_map.php --show src.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1588 Build 1589: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Maybe call updateMap() something like writeMap() or updateAndWriteMap(), it's not as clear as it could be from the outside that "update" implies "write to disk".
Comment Actions
Well, writeMap would be confusing with writeLibraryMap. Maybe buildMap() to generate + return, and buildAndWriteMap() to generate + write.