Paths

Table of Contentst

Differential D9843

Don't build unused linters for the `ArcanistConfigurationDrivenLintEngine`
ClosedPublic
Actions

Authored by avivey on Jul 6 2014, 4:05 AM.

Tags

None

Referenced Files

	F19506293: D9843.id23681.diff
	Fri, Jan 9, 4:43 PM

	F19506161: D9843.id23606.diff
	Fri, Jan 9, 4:41 PM

	F19436728: D9843.id23606.diff
	Sun, Dec 28, 3:32 PM

	F19436725: D9843.id23681.diff
	Sun, Dec 28, 3:32 PM

	F19043379: D9843.id.diff
	Nov 26 2025, 9:49 PM

	F19032095: D9843.diff
	Nov 25 2025, 4:20 AM

	F18906855: D9843.id23681.diff
	Nov 8 2025, 8:42 PM

	F18776534: D9843.id.diff
	Oct 10 2025, 10:18 PM

Subscribers

Details

Reviewers

joshuaspence
epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5124: Arcanist requires external linters to be installed even if they are not used

Commits

rARCdfdaed0b27fb: Don't build unused linters for the `ArcanistConfigurationDrivenLintEngine`

Summary

Fixes T5124.

Test Plan

arc lint on a Phabricator diff that doesn't have JS files doesn't complain on missing JSHint.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1545
Build 1545: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

avivey updated this revision to Diff 23606.Jul 6 2014, 4:05 AM

avivey retitled this revision from to Configuration Driven: Don't build unused linters.

avivey updated this object.

avivey edited the test plan for this revision. (Show Details)

avivey added reviewers: epriestley, joshuaspence.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 6 2014, 4:05 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1545: Diff 23606.Jul 6 2014, 4:06 AM

joshuaspence added a task: T5124: Arcanist requires external linters to be installed even if they are not used.Jul 6 2014, 4:33 AM

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence edited edge metadata.

This looks good to me.

avivey retitled this revision from Configuration Driven: Don't build unused linters to Configuration Driven Lint: Don't build unused linters.Jul 6 2014, 7:48 AM

avivey edited edge metadata.

@epriestley, are you okay with this?

joshuaspence retitled this revision from Configuration Driven Lint: Don't build unused linters to Don't build unused linters for the `ArcanistConfigurationDrivenLintEngine`.Jul 9 2014, 4:43 PM

yep

Closed by commit rARCdfdaed0b27fb (authored by @avivey, committed by @epriestley).

chad mentioned this in T6311: 'arc linters' no longer reports linters as 'Configured', all show as 'Available'.Nov 1 2014, 5:00 PM

Revision Contents
Changeset List

Path

Size

src/

lint/

engine/

ArcanistConfigurationDrivenLintEngine.php

8 lines

Diff 23606

src/lint/engine/ArcanistConfigurationDrivenLintEngine.php

Loading...