Paths

Table of Contentst

Differential D9821

Add an `externals/includes` directory
ClosedPublic
Actions

Authored by joshuaspence on Jul 5 2014, 6:32 AM.

Tags

None

Referenced Files

	F15386769: D9821.id23579.diff
	Sat, Mar 15, 1:16 AM

	F15380714: D9821.id23579.diff
	Fri, Mar 14, 4:12 AM

	F15377857: D9821.id23579.diff
	Thu, Mar 13, 11:04 AM

	F15334876: D9821.id23579.diff
	Sat, Mar 8, 12:54 PM

	F15294690: D9821.diff
	Wed, Mar 5, 10:31 AM

	Unknown Object (File)
	Tue, Feb 25, 5:06 PM

	Unknown Object (File)
	Fri, Feb 21, 10:25 PM

	Unknown Object (File)
	Fri, Feb 21, 3:55 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rPHU5e9381193254: Add an `externals/includes` directory

Summary

Add an externals/includes directory that will be included as a part of PHP's include_path. Arcanist already has similar functionality. Without this, it is hard to invoke the scripts/update_compat_info.php script, which was moved from rARC to rPHU in D9813.

Test Plan

N/A

Diff Detail

Repository

Branch

includes

Lint

Lint Errors

Severity	Location	Code	Message
Error	scripts/__init_script__.php:74	XHP45	PHP Compatibility

Unit

No Test Coverage

Build Status

Buildable 1519
Build 1519: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23570.Jul 5 2014, 6:32 AM

joshuaspence retitled this revision from to Add an `externals/includes` director.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 5 2014, 6:32 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1519: Diff 23570.Jul 5 2014, 6:33 AM

joshuaspence retitled this revision from Add an `externals/includes` director to Add an `externals/includes` directory.Jul 5 2014, 6:55 AM

joshuaspence edited edge metadata.

epriestley accepted this revision.Jul 5 2014, 2:44 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jul 5 2014, 2:44 PM

Closed by commit rPHU5e9381193254 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

1 line

externals/

includes/

3 lines

scripts/

__init_script__.php

8 lines

Diff 23570

.gitignore

Loading...

externals/includes/README

Loading...

scripts/__init_script__.php

Loading...