Fixes T5503. We incorrectly render an encoding note for empty files. Only render an encoding note for text changes with at least one hunk.
Details
Details
- Reviewers
joshuaspence btrahan - Maniphest Tasks
- T5503: Empty file has an unknown character encoding
- Commits
- Restricted Diffusion Commit
rPc1af499ed7ab: Only show text encoding note in Differential if a change has hunks
- Viewed empty file, no note.
- Viewed nonempty file with altered encoding, saw note.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- diff1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1462 Build 1462: [Placeholder Plan] Wait for 30 Seconds