Page MenuHomePhabricator

Set "max-width: 100%" on "size=full" Remarkup images
ClosedPublic

Authored by epriestley on Jun 27 2014, 5:18 PM.
Tags
None
Referenced Files
F13209712: D9758.id23429.diff
Fri, May 17, 1:46 AM
F13209711: D9758.id23431.diff
Fri, May 17, 1:46 AM
F13209710: D9758.id23430.diff
Fri, May 17, 1:46 AM
F13209077: D9758.id23430.diff
Thu, May 16, 9:37 PM
F13187784: D9758.diff
Sat, May 11, 4:44 AM
Unknown Object (File)
Tue, May 7, 7:19 AM
Unknown Object (File)
Fri, May 3, 6:25 AM
Unknown Object (File)
Mon, Apr 29, 6:52 PM
Subscribers

Details

Summary

Fixes T5500. When an image is embedded with {Fxx, size=full}, add "max-width: 100%;" so that large images are scaled down to the size of the container. This seems like a better and more reasonable behavior than having them scroll. You can still lightbox them or right-click -> view if you really want the full image.

Test Plan

Dragged window around with a very large size=full image. At large window sizes, the image displayed at 100%. At smaller window sizes, the image was scaled to fit.

Diff Detail

Repository
rP Phabricator
Branch
maxwidth
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1432
Build 1432: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Set "max-width: 100%" on "size=full" Remarkup images.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 27 2014, 5:27 PM
epriestley updated this revision to Diff 23431.

Closed by commit rP32a42f37feb0 (authored by @epriestley).