Page MenuHomePhabricator
Create Task
Maniphest T5500

Add "size=fit" mode for images
Closed, ResolvedPublic
Actions

Description

Complimentary to "thumb" and "full", "fit" would either display the image as "full" if it fits horizontally within the page or scale it down to fit horizontally exactly.

Revisions and Commits

rP Phabricator
D9758rP32a42f37feb0 Set "max-width: 100%" on "size=full" Remarkup images

Event Timeline

swisspol created this task.Jun 27 2014, 4:44 PM
swisspol raised the priority of this task from to Needs Triage.
swisspol updated the task description. (Show Details)
swisspol added a subscriber: swisspol.
epriestley added a subscriber: epriestley.Jun 27 2014, 4:49 PM

suchwow.jpeg (560×555 px, 23 KB)

epriestley added a comment.Jun 27 2014, 4:50 PM

You can use width=100%. This isn't quite what you're after, because it will also scale up small images.

I'll see if we can do this in CSS with max-width: 100%. If we can't, writing JS for this is probably Wontfix.

swisspol added a comment.Jun 27 2014, 4:53 PM

That's acceptable, thanks.

epriestley edited this Maniphest Task.Jun 27 2014, 5:18 PM
epriestley added a comment.Jun 27 2014, 5:19 PM

max-width: 100% seems to work reasonably well. In effect, D9758 turns "size=full" into "size=fit". (I assume you don't have a use case for the current behavior (scroll all over the place) of "size=full"?)

epriestley added a project: Remarkup.Jun 27 2014, 5:20 PM
epriestley edited this Maniphest Task.Jun 27 2014, 5:29 PM
epriestley closed this task as Resolved.Jun 27 2014, 5:29 PM

Closed by commit rP32a42f37feb0.

swisspol added a comment.Jun 27 2014, 7:19 PM

This solution is better indeed.

Phabricator · Built by Phacility