Differential D9693

Skip the "Too Many Errors" error that is raised by JSHint.
ClosedPublic
Actions

Authored by joshuaspence on Jun 23 2014, 6:04 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC213628ff34de: Skip the "Too Many Errors" error that is raised by JSHint.

Summary

If JSHint encounters too many errors (by default, more than 50) errors, then it quits prematurely and raises an additional (rather unhelpful) "Too Many Errors" error. We should just ignore this additional error.

Test Plan

Added a test case.

Diff Detail

Repository

rARC Arcanist

Branch

jshint-toomanyerrors

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/lint/linter/ArcanistJSHintLinter.php:35	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 1336
Build 1336: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23256.Jun 23 2014, 6:04 PM

joshuaspence retitled this revision from to Skip the "Too Many Errors" error that is raised by JSHint..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 23 2014, 6:04 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1336: Diff 23256.Jun 23 2014, 6:05 PM

Bleh.

This revision is now accepted and ready to land.Jun 23 2014, 6:15 PM

Closed by commit rARC213628ff34de (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistJSHintLinter.php

7 lines

__tests__/

jshint/

too-many-errors.lint-test

5 lines

Diff 23256

View Options

src/lint/linter/ArcanistJSHintLinter.php

View Options

src/lint/linter/tests/jshint/too-many-errors.lint-test

Skip the "Too Many Errors" error that is raised by JSHint.ClosedPublicActions