Paths

Table of Contentst

Differential D9677

Change double quotes to single quotes in JavaScript.
ClosedPublic
Actions

Authored by joshuaspence on Jun 23 2014, 1:32 AM.

Tags

None

Referenced Files

	F14044931: D9677.id.diff
	Tue, Nov 12, 11:02 PM

	F14044754: D9677.id.diff
	Tue, Nov 12, 8:35 PM

	F14043682: D9677.id23225.diff
	Tue, Nov 12, 12:09 PM

	F14041687: D9677.id23250.diff
	Mon, Nov 11, 8:34 PM

	F14039872: D9677.id23253.diff
	Mon, Nov 11, 6:34 AM

	F14038190: D9677.diff
	Sun, Nov 10, 10:05 PM

	F14035631: D9677.id23250.diff
	Sun, Nov 10, 6:50 AM

	F14035626: D9677.id23225.diff
	Sun, Nov 10, 6:49 AM

Subscribers

Details

Reviewers

epriestley
chad

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP79f9d8740104: Change double quotes to single quotes in JavaScript.

Summary

As advised by JSHint.

Test Plan

I'm not really sure how to comprehensively test this. It looks okay to me.

Diff Detail

Repository

Branch

js-singlequote

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/uiexample/notification-example.js:42	W117	JSHintW117
Warning	webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js:130	W033	JSHintW033
Warning	webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js:130	W116	JSHintW116

Unit

No Test Coverage

Build Status

Buildable 1315
Build 1315: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 23225.Jun 23 2014, 1:32 AM

joshuaspence retitled this revision from to Change double quotes to single quotes in JavaScript..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added reviewers: epriestley, chad.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 23 2014, 1:32 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1315: Diff 23225.Jun 23 2014, 1:33 AM

I think I caught one real issue.

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js
130	I think this removes a `)` and introduces a syntax error.

This revision now requires changes to proceed.Jun 23 2014, 4:08 PM

joshuaspence added inline comments.Jun 23 2014, 4:10 PM

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js
130	Yeah you're right. Interesting that JSHint only raises this as a warning.

Fix syntax error

Harbormaster completed remote builds in B1332: Diff 23250.Jun 23 2014, 5:32 PM

epriestley accepted this revision.Jun 23 2014, 5:33 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 23 2014, 5:33 PM

Closed by commit rP79f9d8740104 (authored by @joshuaspence).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

356 lines

webroot/

rsrc/

js/

application/

aphlict/

behavior-aphlict-dropdown.js

2 lines

diffusion/

DiffusionLocateFileSource.js

2 lines

maniphest/

behavior-line-chart.js

4 lines

owners/

OwnersPathEditor.js

8 lines

policy/

behavior-policy-rule-editor.js

6 lines

transactions/

behavior-transaction-list.js

4 lines

uiexample/

ReactorButtonExample.js

2 lines

ReactorMouseoverExample.js

2 lines

notification-example.js

2 lines

core/

DraggableList.js

2 lines

2 lines

MultirowRowManager.js

20 lines

behavior-dark-console.js

2 lines

behavior-drag-and-drop-textarea.js

2 lines

behavior-fancy-datepicker.js

4 lines

behavior-object-selector.js

2 lines

behavior-oncopy.js

6 lines

behavior-phabricator-remarkup-assist.js

12 lines

Diff 23225

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js

Loading...

webroot/rsrc/js/application/diffusion/DiffusionLocateFileSource.js

Loading...

webroot/rsrc/js/application/maniphest/behavior-line-chart.js

Loading...

webroot/rsrc/js/application/owners/OwnersPathEditor.js

Loading...

webroot/rsrc/js/application/policy/behavior-policy-rule-editor.js

Loading...

webroot/rsrc/js/application/transactions/behavior-transaction-list.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorButtonExample.js

Loading...

webroot/rsrc/js/application/uiexample/ReactorMouseoverExample.js

Loading...

webroot/rsrc/js/application/uiexample/notification-example.js

Loading...

webroot/rsrc/js/core/DraggableList.js

Loading...

webroot/rsrc/js/core/Hovercard.js

Loading...

webroot/rsrc/js/core/MultirowRowManager.js

Loading...

webroot/rsrc/js/core/behavior-dark-console.js

Loading...

webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js

Loading...

webroot/rsrc/js/core/behavior-fancy-datepicker.js

Loading...

webroot/rsrc/js/core/behavior-object-selector.js

Loading...

webroot/rsrc/js/core/behavior-oncopy.js

Loading...

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...