Page MenuHomePhabricator
Differential D9677

Change double quotes to single quotes in JavaScript.
ClosedPublic
Actions

Authored by joshuaspence on Jun 23 2014, 1:32 AM.
Tags
None
Referenced Files
F14008226: D9677.diff
Tue, Oct 29, 6:04 PM
F13974219: D9677.diff
Fri, Oct 18, 4:34 AM
Unknown Object (File)
Fri, Oct 11, 11:55 PM
Unknown Object (File)
Fri, Oct 11, 11:53 PM
Unknown Object (File)
Fri, Oct 11, 11:53 PM
Unknown Object (File)
Sep 20 2024, 4:19 AM
Unknown Object (File)
Sep 20 2024, 2:29 AM
Unknown Object (File)
Sep 19 2024, 2:58 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP79f9d8740104: Change double quotes to single quotes in JavaScript.
Summary

As advised by JSHint.

Test Plan

I'm not really sure how to comprehensively test this. It looks okay to me.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23225.Jun 23 2014, 1:32 AM
joshuaspence retitled this revision from to Change double quotes to single quotes in JavaScript..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, chad.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 23 2014, 1:32 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B1315: Diff 23225.Jun 23 2014, 1:33 AM
epriestley requested changes to this revision.Jun 23 2014, 4:08 PM
epriestley edited edge metadata.

I think I caught one real issue.

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js
130

I think this removes a ) and introduces a syntax error.

This revision now requires changes to proceed.Jun 23 2014, 4:08 PM
joshuaspence added inline comments.Jun 23 2014, 4:10 PM
webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js
130

Yeah you're right. Interesting that JSHint only raises this as a warning.

joshuaspence updated this revision to Diff 23250.Jun 23 2014, 5:30 PM
joshuaspence edited edge metadata.
  • Fix syntax error
Harbormaster completed remote builds in B1332: Diff 23250.Jun 23 2014, 5:32 PM
epriestley accepted this revision.Jun 23 2014, 5:33 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 23 2014, 5:33 PM
joshuaspence closed this revision.Jun 23 2014, 5:35 PM
joshuaspence updated this revision to Diff 23253.

Closed by commit rP79f9d8740104 (authored by @joshuaspence).

Revision Contents
Changeset List

Diff 23253

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js

Loading...
View Options

webroot/rsrc/js/application/diffusion/DiffusionLocateFileSource.js

Loading...
View Options

webroot/rsrc/js/application/maniphest/behavior-line-chart.js

Loading...
View Options

webroot/rsrc/js/application/owners/OwnersPathEditor.js

Loading...
View Options

webroot/rsrc/js/application/policy/behavior-policy-rule-editor.js

Loading...
View Options

webroot/rsrc/js/application/transactions/behavior-transaction-list.js

Loading...
View Options

webroot/rsrc/js/application/uiexample/ReactorButtonExample.js

Loading...
View Options

webroot/rsrc/js/application/uiexample/ReactorMouseoverExample.js

Loading...
View Options

webroot/rsrc/js/application/uiexample/notification-example.js

Loading...
View Options

webroot/rsrc/js/core/DraggableList.js

Loading...
View Options

webroot/rsrc/js/core/Hovercard.js

Loading...
View Options

webroot/rsrc/js/core/MultirowRowManager.js

Loading...
View Options

webroot/rsrc/js/core/behavior-dark-console.js

Loading...
View Options

webroot/rsrc/js/core/behavior-drag-and-drop-textarea.js

Loading...
View Options

webroot/rsrc/js/core/behavior-fancy-datepicker.js

Loading...
View Options

webroot/rsrc/js/core/behavior-object-selector.js

Loading...
View Options

webroot/rsrc/js/core/behavior-oncopy.js

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...
Phabricator · Built by Phacility