Fixes T5437. This actual behavior is debateable but this is the one that seems simplest and most sensible.
Details
Details
- Reviewers
btrahan chad - Maniphest Tasks
- T5437: Copy-pasting from Numbers and some other apps both insert text and upload a file
- Commits
- Restricted Diffusion Commit
rPa496d4aa4251: When pasting both image data and text into Chrome, use only the text
Copied some cells from Numbers, pasted them into a remarkup box in Chrome, got just the text.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- nodualpaste
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1273 Build 1273: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I feel like the expectation is either both text and image, or just text. It feels weird to special case this either way. Thoughts?
Comment Actions
See T5437 for some discussion.
I could pretty much go either way:
- I think adding both is sort of confusing.
- When there are a bunch of cells, in a grid, the image seems way better.
- When there's only one column or row of cells, the text seems better?
- When there's only one cell, the text seems way better.
My ideal behavior is probably to prompt the user and ask, I guess? I think there are cases where one option or the other is far more desirable, and we probably can't guess which one is better. But this has a high degree of implementation complexity.
Comment Actions
- If there's any text, use that instead.
- This produces better results for files, Word, and probably more reasonable for Numbers.