Page MenuHomePhabricator

When pasting both image data and text into Chrome, use only the text
ClosedPublic

Authored by epriestley on Jun 21 2014, 3:17 PM.

Details

Summary

Fixes T5437. This actual behavior is debateable but this is the one that seems simplest and most sensible.

Test Plan

Copied some cells from Numbers, pasted them into a remarkup box in Chrome, got just the text.

Diff Detail

Repository
rP Phabricator
Branch
nodualpaste
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1273
Build 1273: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to When pasting both image data and text into Chrome, use only the image.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.

I feel like the expectation is either both text and image, or just text. It feels weird to special case this either way. Thoughts?

See T5437 for some discussion.

I could pretty much go either way:

  • I think adding both is sort of confusing.
  • When there are a bunch of cells, in a grid, the image seems way better.
  • When there's only one column or row of cells, the text seems better?
  • When there's only one cell, the text seems way better.

My ideal behavior is probably to prompt the user and ask, I guess? I think there are cases where one option or the other is far more desirable, and we probably can't guess which one is better. But this has a high degree of implementation complexity.

epriestley edited edge metadata.
  • If there's any text, use that instead.
  • This produces better results for files, Word, and probably more reasonable for Numbers.
epriestley retitled this revision from When pasting both image data and text into Chrome, use only the image to When pasting both image data and text into Chrome, use only the text.Jun 21 2014, 4:47 PM
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 21 2014, 4:53 PM
epriestley updated this revision to Diff 23153.

Closed by commit rPa496d4aa4251 (authored by @epriestley).