Page MenuHomePhabricator

Fix an issue with `arc branch` and very old branches
ClosedPublic

Authored by epriestley on Jun 18 2014, 12:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 1:50 AM
Unknown Object (File)
Thu, Dec 26, 1:41 AM
Unknown Object (File)
Fri, Dec 20, 4:22 PM
Unknown Object (File)
Fri, Dec 13, 1:15 PM
Unknown Object (File)
Thu, Dec 12, 10:54 PM
Unknown Object (File)
Dec 3 2024, 12:16 AM
Unknown Object (File)
Dec 2 2024, 4:02 PM
Unknown Object (File)
Nov 27 2024, 3:48 AM
Subscribers

Details

Summary

In D9595, we stopped parsing short-form "Differential Revision:" fields in commit messages, and only accept URLs.

I have one of the older style commit messages in my local arcanist/, so now we go down this parse failure branch in arc branch. This has never worked quite correctly, and if the parse fails we end up with a bad branch dictionary that is missing fields.

Test Plan

Ran arc branch in a working copy with an old Differential Revision: field at the head of a branch. Before patch: explosions; after patch: works great.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix an issue with `arc branch` and very old branches.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: joshuaspence.
This revision is now accepted and ready to land.Jun 18 2014, 3:32 PM
epriestley updated this revision to Diff 23070.

Closed by commit rARC2198cc2849c8 (authored by @epriestley).