Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4418: Make it possible to create tasks attached to a project through "arc todo"
- Commits
- Restricted Diffusion Commit
rP396433672237: Include project slugs in the results of a `project.query` Conduit call.
Made a conduit call with arc:
> echo '{"slugs": ["foo"]}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit project.query
Waiting for JSON parameters on stdin...
{"error":null,"errorMessage":null,"response":{"data":{"PHID-PROJ-ttomlhslujpx5sdpbu2c":{"id":"1","phid":"PHID-PROJ-ttomlhslujpx5sdpbu2c","name":"Foo","members":["PHID-USER-cb5af6p4oepy5tlgqypi"],"slugs":["foo","bar"],"dateCreated":"1402422720","dateModified":"1402422728"}},"slugMap":{"foo":"PHID-PROJ-ttomlhslujpx5sdpbu2c"},"cursor":{"limit":100,"after":null,"before":null}}}Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- project_query-slugs
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1215 Build 1215: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
- Nest data returned from project.query into 'data' subkey.
- Paginate results.
- Add a slug map
- Need slugs
- Fix slugMap
- Fix slugs return value
- Fix slug map.
Comment Actions
Example output
> echo '{"slugs": ["foo"]}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit project.query
Waiting for JSON parameters on stdin...
{"error":null,"errorMessage":null,"response":{"data":{"PHID-PROJ-ttomlhslujpx5sdpbu2c":{"id":"1","phid":"PHID-PROJ-ttomlhslujpx5sdpbu2c","name":"Foo","members":["PHID-USER-cb5af6p4oepy5tlgqypi"],"slugs":["foo","bar"],"dateCreated":"1402422720","dateModified":"1402422728"}},"slugMap":{"foo":"1"},"cursor":{"limit":100,"after":null,"before":null}}}Comment Actions
We can fix the map construction later, I think we should be normalizing slugs here anyway (so "DiFfuSIon" matches "diffusion").
| src/applications/project/conduit/ConduitAPI_project_query_Method.php | ||
|---|---|---|
| 95 ↗ | (On Diff #23274) | This should probably be phid, given that $projects ends up keyed by PHID? |