Include project slugs in the results of a `project.query` Conduit call.
ClosedPublic
Actions

Authored by joshuaspence on Jun 18 2014, 6:42 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4418: Make it possible to create tasks attached to a project through "arc todo"

Commits

Restricted Diffusion Commit
rP396433672237: Include project slugs in the results of a `project.query` Conduit call.

Summary

Ref T4418. This feature will be used by D9457 to determine whether the specified slugs exist.

Test Plan

Made a conduit call with arc:

> echo '{"slugs": ["foo"]}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit project.query
Waiting for JSON parameters on stdin...
{"error":null,"errorMessage":null,"response":{"data":{"PHID-PROJ-ttomlhslujpx5sdpbu2c":{"id":"1","phid":"PHID-PROJ-ttomlhslujpx5sdpbu2c","name":"Foo","members":["PHID-USER-cb5af6p4oepy5tlgqypi"],"slugs":["foo","bar"],"dateCreated":"1402422720","dateModified":"1402422728"}},"slugMap":{"foo":"PHID-PROJ-ttomlhslujpx5sdpbu2c"},"cursor":{"limit":100,"after":null,"before":null}}}

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 23063.Jun 18 2014, 6:42 AM

joshuaspence retitled this revision from to Include project slugs in the results of a `project.query` Conduit call..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2014, 6:42 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1215: Diff 23063.Jun 18 2014, 6:44 AM

joshuaspence updated this object.Jun 18 2014, 6:51 AM

joshuaspence edited edge metadata.

joshuaspence added a task: T4418: Make it possible to create tasks attached to a project through "arc todo" .

epriestley accepted this revision.Jun 18 2014, 12:11 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 18 2014, 12:11 PM

Nest data returned from project.query into 'data' subkey.
Paginate results.
Add a slug map
Need slugs
Fix slugMap
Fix slugs return value
Fix slug map.

I've updated this diff to reflect D9457#25.

Example output

> echo '{"slugs": ["foo"]}' | arc --conduit-uri='http://phabricator.joshuaspence.com' call-conduit project.query
Waiting for JSON parameters on stdin...
{"error":null,"errorMessage":null,"response":{"data":{"PHID-PROJ-ttomlhslujpx5sdpbu2c":{"id":"1","phid":"PHID-PROJ-ttomlhslujpx5sdpbu2c","name":"Foo","members":["PHID-USER-cb5af6p4oepy5tlgqypi"],"slugs":["foo","bar"],"dateCreated":"1402422720","dateModified":"1402422728"}},"slugMap":{"foo":"1"},"cursor":{"limit":100,"after":null,"before":null}}}

Harbormaster completed remote builds in B1343: Diff 23274.Jun 23 2014, 7:48 PM