Ref T1049. This moves the declaration of build variables onto HarbormasterBuildableInterface, allowing new classes implementing HarbormasterBuildableInterface to declare their own variables.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T1049: Implement Harbormaster
- Commits
- Restricted Diffusion Commit
rPf7f866445681: Move build variables into HarbormasterBuildableInterface
Implemented it on another class, saw the build variables appear.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- build-variables
- Lint
Lint Passed Severity Location Code Message Advice src/applications/harbormaster/storage/build/HarbormasterBuild.php:238 XHP16 TODO Comment Advice src/applications/harbormaster/storage/build/HarbormasterBuild.php:242 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 1213 Build 1213: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Minor inlines, looks good overall.
| src/applications/harbormaster/storage/build/HarbormasterBuild.php | ||
|---|---|---|
| 238–241 | Yes, this is guaranteed. | |
| 243–245 | Try: $results = $object_variables + $results; (Note that order is important; in $a = $b + $c, if a key is present in both $b and $c, the value in $b wins.) | |
| 256 | Use loadObjects(): it's a little simpler, and it makes sure you don't get abstract subclasses back. | |
| 267 | Then, this loop will just be foreach ($objects as $object) and you don't need new. | |