Move build variables into HarbormasterBuildableInterface
ClosedPublic
Actions

Authored by hach-que on Jun 18 2014, 5:47 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T1049: Implement Harbormaster

Commits

Restricted Diffusion Commit
rPf7f866445681: Move build variables into HarbormasterBuildableInterface

Summary

Ref T1049. This moves the declaration of build variables onto HarbormasterBuildableInterface, allowing new classes implementing HarbormasterBuildableInterface to declare their own variables.

Test Plan

Implemented it on another class, saw the build variables appear.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hach-que updated this revision to Diff 23061.Jun 18 2014, 5:47 AM

hach-que retitled this revision from to Move build variables into HarbormasterBuildableInterface.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

hach-que added a task: T1049: Implement Harbormaster.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 18 2014, 5:47 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1213: Diff 23061.Jun 18 2014, 5:48 AM

Fix missing conditional

Harbormaster completed remote builds in B1214: Diff 23062.Jun 18 2014, 5:53 AM

Minor inlines, looks good overall.

src/applications/harbormaster/storage/build/HarbormasterBuild.php
238–239	Yes, this is guaranteed.
240–242	Try: $results = $object_variables + $results; (Note that order is important; in `$a = $b + $c`, if a key is present in both `$b` and `$c`, the value in `$b` wins.)
251	Use `loadObjects()`: it's a little simpler, and it makes sure you don't get abstract subclasses back.
262	Then, this loop will just be `foreach ($objects as $object)` and you don't need `new`.