Ref T4725.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T4725: `arc liberate` should throw when encountering (and eventually support) namespaces and traits
- Commits
- rARC3810cdbbccff: Let `arc liberate` throw on unsupported PHP features
add some files that have unsupported constructs all over the place and run arc liberate
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- arcpatch-D9585
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1172 Build 1172: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
This generally seems pretty reasonable to me. What sort of issues do you think it has?
One minor nitpick: it's sometimes hard/impossible to translate sentence fragments into other languages and end up with natural-sounding grammar. It would be better to just name the feature in $what (e.g., "namespaces" instead of "use a namespace") and then use an error string like this:
arc liberate has limited support for features introduced after PHP 5.2.3. This library uses an unsupported feature (%s) on line %d of %s
Then you can just pass "namespaces", "traits", "namespace 'use' statements", etc.
Comment Actions
Closed by commit rARC3810cdbbccff (authored by @richardvanvelzen, committed by @epriestley).