Page MenuHomePhabricator

Move the "ragged classtree edge" linter rule to `ArcanistPhutilXHPASTLinter`.
ClosedPublic

Authored by joshuaspence on Jun 17 2014, 2:37 AM.
Tags
None
Referenced Files
F14388015: D9590.diff
Sat, Dec 21, 3:30 PM
Unknown Object (File)
Thu, Dec 12, 11:35 PM
Unknown Object (File)
Mon, Dec 9, 4:23 AM
Unknown Object (File)
Sun, Dec 8, 4:28 PM
Unknown Object (File)
Sat, Dec 7, 3:42 PM
Unknown Object (File)
Mon, Dec 2, 4:03 PM
Unknown Object (File)
Tue, Nov 26, 5:04 PM
Unknown Object (File)
Sun, Nov 24, 1:22 PM
Subscribers

Details

Summary

This linter rule is very specific to the Phabricator and it is unlikely that it is being used elsewhere. We should move it to ArcanistPhutilXHPASTLinter, where other Phabricator-specific linting code lives.

Test Plan

Moved the corresponding test case.

Diff Detail

Repository
rARC Arcanist
Branch
xhpast-ragged
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1163
Build 1163: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Move the "ragged classtree edge" linter rule to `ArcanistPhutilXHPASTLinter`..
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 17 2014, 11:10 AM