Differential D9577

Check for calendar before settings status
ClosedPublic
Actions

Authored by garoevans on Jun 16 2014, 7:10 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T5370: User pop-ups shouldn't show "Status: ..." line if Calendar app is uninstalled

Commits

Restricted Diffusion Commit
rP824b8108da41: Check for calendar before settings status

Summary

We should not show the status line in the people hover card
if the calendar app has been uninstalled or is not available for the
current user.

Test Plan

View hover card with calendar installed and uninstalled.
Make sure I see the status at the correct time.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

garoevans updated this revision to Diff 22951.Jun 16 2014, 7:10 PM

garoevans added a task: T5370: User pop-ups shouldn't show "Status: ..." line if Calendar app is uninstalled.

garoevans retitled this revision from to Check for calendar before settings status.

garoevans updated this object.

garoevans edited the test plan for this revision. (Show Details)

garoevans added a reviewer: epriestley.

garoevans added a subscriber: chad.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 16 2014, 7:10 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1147: Diff 22951.Jun 16 2014, 7:11 PM

epriestley accepted this revision.Jun 16 2014, 7:17 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2014, 7:17 PM

Closed by commit rP824b8108da41 (authored by @garoevans, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

event/

PhabricatorPeopleHovercardEventListener.php

4 lines

Diff 22952

View Options

src/applications/people/event/PhabricatorPeopleHovercardEventListener.php

Check for calendar before settings statusClosedPublicActions