Page MenuHomePhabricator

Make query panels editable by normal humans
ClosedPublic

Authored by epriestley on Jun 16 2014, 3:14 PM.
Tags
None
Referenced Files
F14359452: D9572.id22955.diff
Fri, Dec 20, 9:25 AM
Unknown Object (File)
Thu, Dec 19, 4:11 AM
Unknown Object (File)
Thu, Dec 12, 1:35 AM
Unknown Object (File)
Mon, Dec 9, 2:49 PM
Unknown Object (File)
Sun, Dec 8, 3:49 PM
Unknown Object (File)
Tue, Dec 3, 6:27 PM
Unknown Object (File)
Sat, Nov 30, 3:01 PM
Unknown Object (File)
Fri, Nov 29, 5:25 PM
Subscribers
Tokens
"Yellow Medal" token, awarded by chad.

Details

Summary

Ref T4986. Instead of requiring you to know engine class names and copy/paste URLs, provide select dropdowns that use SCARY JAVASCRIPT to do magical things.

I think this is mostly reasonable, the only issue is that it's hard to create a panel out of a completely ad-hoc query (you'd have to save it, then create a panel out of the saved query, then remove the saved query). Once we develop T5307 we can do a better job of this.

Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Branch
dash1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1140
Build 1140: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make query panels editable by normal humans.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

What it looks like:

Screen_Shot_2014-06-16_at_8.09.08_AM.png (1×1 px, 213 KB)

The "Query" control dynamically changes based on the value selected in the "Application" control. Wizardry!

chad edited edge metadata.
This revision is now accepted and ready to land.Jun 16 2014, 4:21 PM
epriestley updated this revision to Diff 22955.

Closed by commit rP5aae1ee034ab (authored by @epriestley).