Page MenuHomePhabricator

Ensure Aphlict is served on the primary domain
ClosedPublic

Authored by hach-que on Jun 13 2014, 8:11 AM.
Tags
None
Referenced Files
F14020579: D9511.id22791.diff
Wed, Nov 6, 12:51 AM
F14012407: D9511.id22790.diff
Fri, Nov 1, 11:57 AM
F14010143: D9511.id22789.diff
Thu, Oct 31, 5:28 AM
F14009876: D9511.id22790.diff
Thu, Oct 31, 1:31 AM
F14008188: D9511.id22790.diff
Tue, Oct 29, 5:12 PM
F14005189: D9511.id22789.diff
Sun, Oct 27, 8:45 AM
F14003434: D9511.id22790.diff
Sat, Oct 26, 6:09 AM
F14000915: D9511.id22789.diff
Fri, Oct 25, 2:21 AM
Subscribers

Details

Summary

This ensure that Aphlict is always served on the primary / production domain, because the alternate file domain is intended to prevent Flash execution.

Test Plan

Confirmed this fixes the issue by visiting https://code.redpointsoftware.com.au/ and seeing notification messages.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Skipped
Unit
Tests Passed
Build Status
Buildable 1048
Build 1048: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Ensure Aphlict is served on the primary domain.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added reviewers: joshuaspence, epriestley.

I upgrade Arcanist to fix the lint issue, but then it complained about not having jshint installed anyway (and installing it from NPM complains about a dependency error).

epriestley edited edge metadata.

Let's just add a flag to $response->getURI() that makes it choose getURI() instead of getCDNURI() at the end?

This revision now requires changes to proceed.Jun 13 2014, 12:04 PM
hach-que edited edge metadata.

Add optional argument

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2014, 12:46 PM

Thanks! Sorry about missing this.

epriestley updated this revision to Diff 22793.

Closed by commit rP3dc7876117f3 (authored by @hach-que, committed by @epriestley).