Page MenuHomePhabricator

Ensure Aphlict is served on the primary domain
ClosedPublic

Authored by hach-que on Jun 13 2014, 8:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 3, 9:27 PM
Unknown Object (File)
Mon, Sep 2, 3:54 PM
Unknown Object (File)
Sat, Aug 31, 6:52 AM
Unknown Object (File)
Thu, Aug 29, 9:14 PM
Unknown Object (File)
Mon, Aug 26, 1:21 AM
Unknown Object (File)
Sun, Aug 25, 6:09 AM
Unknown Object (File)
Fri, Aug 23, 5:49 PM
Unknown Object (File)
Aug 20 2024, 9:19 AM
Subscribers

Details

Summary

This ensure that Aphlict is always served on the primary / production domain, because the alternate file domain is intended to prevent Flash execution.

Test Plan

Confirmed this fixes the issue by visiting https://code.redpointsoftware.com.au/ and seeing notification messages.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Skipped
Unit
Tests Passed
Build Status
Buildable 1049
Build 1049: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que retitled this revision from to Ensure Aphlict is served on the primary domain.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added reviewers: joshuaspence, epriestley.

I upgrade Arcanist to fix the lint issue, but then it complained about not having jshint installed anyway (and installing it from NPM complains about a dependency error).

epriestley edited edge metadata.

Let's just add a flag to $response->getURI() that makes it choose getURI() instead of getCDNURI() at the end?

This revision now requires changes to proceed.Jun 13 2014, 12:04 PM
hach-que edited edge metadata.

Add optional argument

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jun 13 2014, 12:46 PM

Thanks! Sorry about missing this.

epriestley updated this revision to Diff 22793.

Closed by commit rP3dc7876117f3 (authored by @hach-que, committed by @epriestley).