Differential D9478

Use JS to manage dashboard tab panels
ClosedPublic
Actions

Authored by epriestley on Jun 11 2014, 4:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 3, 10:59 PM

	Unknown Object (File)
	Sun, Mar 2, 1:42 PM

	Unknown Object (File)
	Mon, Feb 24, 11:56 AM

	Unknown Object (File)
	Sun, Feb 9, 1:29 PM

	Unknown Object (File)
	Sun, Feb 9, 1:29 PM

	Unknown Object (File)
	Sun, Feb 9, 1:29 PM

	Unknown Object (File)
	Sun, Feb 9, 1:29 PM

	Unknown Object (File)
	Jan 24 2025, 4:53 AM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T5271: Dashboard Panel "Tabs" should setSelected to pick up CSS

Commits

Restricted Diffusion Commit
rPce887d55c2e5: Use JS to manage dashboard tab panels

Summary

Fixes T5271. This is mostly similar to normal tab panel JS, but I think we'll eventually do async rendering and/or saved tabs so it's reasonable to split it out.

Test Plan

Toggled tabs on a tab panel, saw tab selected state change.

Diff Detail

Repository

Branch

dash1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php:76	XHP16	TODO Comment
Advice	src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php:79	XHP16	TODO Comment

Unit

No Test Coverage

Build Status

Buildable 1001
Build 1001: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 22662.Jun 11 2014, 4:28 PM

epriestley retitled this revision from to Use JS to manage dashboard tab panels.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T5271: Dashboard Panel "Tabs" should setSelected to pick up CSS.

Herald added a subscriber: epriestley. · View Herald TranscriptJun 11 2014, 4:28 PM

Harbormaster completed remote builds in B1001: Diff 22662.Jun 11 2014, 4:30 PM

chad accepted this revision.Jun 11 2014, 4:34 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jun 11 2014, 4:34 PM

Closed by commit rPce887d55c2e5 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

18 lines

src/

applications/

dashboard/

paneltype/

PhabricatorDashboardPanelTypeTabs.php

38 lines

webroot/

rsrc/

js/

application/

dashboard/

behavior-dashboard-tab-panel.js

38 lines

Diff 22662

resources/celerity/map.php

Loading...

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php

Loading...

webroot/rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js

Loading...