Page MenuHomePhabricator
Create Task
Maniphest T5271

Dashboard Panel "Tabs" should setSelected to pick up CSS
Closed, ResolvedPublic
Actions

Description

I tried to easily fix this as an incompetent engineer, and waved my hands around after 10 minutes. Works great on Files!

Revisions and Commits

rP Phabricator
D9478rPce887d55c2e5 Use JS to manage dashboard tab panels

Event Timeline

chad created this task.Jun 5 2014, 6:17 PM
chad raised the priority of this task from to Normal.
chad updated the task description. (Show Details)
chad added a project: Dashboards.
chad added subscribers: chad, epriestley, lpriestley, btrahan.
epriestley added a comment.Jun 5 2014, 6:18 PM

yeah this is "hard" in the sense of "javascript"

We also load all the panels immediately, but should probably load them only when a tab is selected.

And maaaaaaaaaaybe we should save which tab you have selected, but holding that until after we have other use cases for persistent per-user data on dashboards probably makes sense.

chad added a comment.Jun 5 2014, 6:20 PM

My use case was a toggle for Tasks on UltraDash++

undefined (171×338 px, 32 KB)

epriestley moved this task to Evan on the Dashboards board.Jun 8 2014, 8:09 PM
epriestley claimed this task.Jun 11 2014, 4:27 PM
epriestley edited this Maniphest Task.Jun 11 2014, 4:28 PM
epriestley edited this Maniphest Task.Jun 11 2014, 5:39 PM
epriestley closed this task as Resolved.Jun 11 2014, 5:39 PM

Closed by commit rPce887d55c2e5.

Phabricator · Built by Phacility