Page MenuHomePhabricator
Differential D9478

Use JS to manage dashboard tab panels
ClosedPublic
Actions

Authored by epriestley on Jun 11 2014, 4:28 PM.
Tags
None
Referenced Files
F14035167: D9478.diff
Sun, Nov 10, 4:36 AM
F14035140: D9478.diff
Sun, Nov 10, 4:30 AM
F14021242: D9478.diff
Wed, Nov 6, 6:47 AM
F13973878: D9478.id.diff
Fri, Oct 18, 3:06 AM
F13965882: D9478.id22662.diff
Wed, Oct 16, 4:50 AM
Unknown Object (File)
Oct 10 2024, 10:09 AM
Unknown Object (File)
Oct 10 2024, 10:09 AM
Unknown Object (File)
Oct 10 2024, 10:09 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5271: Dashboard Panel "Tabs" should setSelected to pick up CSS
Commits
Restricted Diffusion Commit
rPce887d55c2e5: Use JS to manage dashboard tab panels
Summary

Fixes T5271. This is mostly similar to normal tab panel JS, but I think we'll eventually do async rendering and/or saved tabs so it's reasonable to split it out.

Test Plan

Toggled tabs on a tab panel, saw tab selected state change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley updated this revision to Diff 22662.Jun 11 2014, 4:28 PM
epriestley retitled this revision from to Use JS to manage dashboard tab panels.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T5271: Dashboard Panel "Tabs" should setSelected to pick up CSS.
Herald added a subscriber: epriestley. · View Herald TranscriptJun 11 2014, 4:28 PM
Harbormaster completed remote builds in B1001: Diff 22662.Jun 11 2014, 4:30 PM
chad accepted this revision.Jun 11 2014, 4:34 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jun 11 2014, 4:34 PM
epriestley closed this revision.Jun 11 2014, 5:39 PM
epriestley updated this revision to Diff 22674.

Closed by commit rPce887d55c2e5 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
resources/
celerity/
18 lines
src/
applications/
dashboard/
paneltype/
38 lines
webroot/
rsrc/
js/
application/
dashboard/
38 lines

Diff 22674

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardPanelTypeTabs.php

Loading...
View Options

webroot/rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js

Loading...
Phabricator · Built by Phacility