Paths

Table of Contentst

Differential D9423

Make Aphlict errors persistent.
ClosedPublic
Actions

Authored by joshuaspence on Jun 7 2014, 10:17 PM.

Tags

None

Referenced Files

	F14032977: D9423.diff
	Sat, Nov 9, 4:21 PM

	F14018676: D9423.diff
	Tue, Nov 5, 6:19 PM

	Unknown Object (File)
	Oct 10 2024, 11:02 AM

	Unknown Object (File)
	Oct 10 2024, 11:02 AM

	Unknown Object (File)
	Oct 10 2024, 11:02 AM

	Unknown Object (File)
	Oct 10 2024, 10:58 AM

	Unknown Object (File)
	Sep 19 2024, 9:24 PM

	Unknown Object (File)
	Sep 18 2024, 6:05 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPbb6fb249666d: Make Aphlict errors persistent.

Summary

Since an error is bad and means that some sort of action is required, make Aphlict error notifications persistent (i.e. they won't dismiss until being clicked).

Test Plan

Loaded a page with notifications.enabled set to true but without the Aphlict server actually running. Noticed that the error message didn't dismiss automatically.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

joshuaspence updated this revision to Diff 22504.Jun 7 2014, 10:17 PM

joshuaspence retitled this revision from to Make Aphlict errors persistent..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 7 2014, 10:17 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B923: Diff 22504.Jun 7 2014, 10:18 PM

epriestley accepted this revision.Jun 9 2014, 6:43 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 9 2014, 6:43 PM

Closed by commit rPbb6fb249666d (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

webroot/

rsrc/

js/

application/

aphlict/

behavior-aphlict-listen.js

1 line

Diff 22525

webroot/rsrc/js/application/aphlict/behavior-aphlict-listen.js

Loading...