Paths

Table of Contentst

Differential D9422

Improve error handling for Aphlict.
ClosedPublic
Actions

Authored by joshuaspence on Jun 7 2014, 10:06 PM.

Tags

None

Referenced Files

	F13184153: D9422.diff
	Fri, May 10, 3:50 PM

	Unknown Object (File)
	Tue, May 7, 5:11 AM

	Unknown Object (File)
	Fri, May 3, 2:34 AM

	Unknown Object (File)
	Mon, Apr 29, 2:04 PM

	Unknown Object (File)
	Wed, Apr 24, 9:55 PM

	Unknown Object (File)
	Tue, Apr 23, 1:20 AM

	Unknown Object (File)
	Sun, Apr 21, 4:17 PM

	Unknown Object (File)
	Sat, Apr 20, 7:01 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP7d255aedba43: Improve error handling for Aphlict.

Summary

Currently, any error thrown when instantiating an AphlictMaster will be assumed to be due to the master already existing. This is a bit overzealous because the documentation specifically states than an ArgumentError will be throw if "the LocalConnection instance is already connected".

Test Plan

Inspected the log message.

Diff Detail

Repository

Branch

aphlict-argerror

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 922
Build 922: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 22502.Jun 7 2014, 10:06 PM

joshuaspence retitled this revision from to Improve error handling for Aphlict..

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 7 2014, 10:06 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B922: Diff 22502.Jun 7 2014, 10:08 PM

epriestley accepted this revision.Jun 7 2014, 10:16 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jun 7 2014, 10:16 PM

Closed by commit rP7d255aedba43 (authored by @joshuaspence, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

support/

aphlict/

client/

src/

AphlictClient.as

5 lines

webroot/

rsrc/

swf/

Diff 22502

support/aphlict/client/src/AphlictClient.as

Loading...

webroot/rsrc/swf/aphlict.swf

Loading...